neurodocker icon indicating copy to clipboard operation
neurodocker copied to clipboard

Support for invalid-Python-keyword labels in API

Open tclose opened this issue 3 years ago • 3 comments

Label names in Docker can have '.'s in them (e.g. org.nrg.commands is a special label used in XNAT's container service) but the syntax of the API, i.e. _Renderer.label(label_name=label_content), doesn't support that

tclose avatar Apr 13 '22 02:04 tclose

Could this be handled by adding a labels method that takes a dictionary of labels to add, e.g. _Renderer.labels({'label_name': label_content})?

tclose avatar Apr 28 '22 06:04 tclose

@tclose - good catch. it's a little clunky, but for now could you try

_Renderer.labels(**{"label.name": "label_content"})

but i agree that labels with . in them should be supported. your proposed solution would be great. prs are welcome ;)

kaczmarj avatar Apr 29 '22 15:04 kaczmarj

can we close this now that #453 has been merged?

kaczmarj avatar Aug 04 '22 17:08 kaczmarj

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Sep 08 '23 01:09 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Nov 11 '23 01:11 github-actions[bot]