FanControl.ADLX icon indicating copy to clipboard operation
FanControl.ADLX copied to clipboard

fancontrol crashes with: Couldn't terminate ADLX

Open hmsta opened this issue 1 year ago • 5 comments

every morning when I wake up my windows 10 pc from sleep fancontrol is gone.

I checked the log and it looks to me that the ADLX plugin is causing a crash when the PC wakes up?

17.05.2024 10:00:36: ADLXWrapper.ADLXEception: Result: ADLX_ORPHAN_OBJECTS 
Couldn't terminate ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei ADLXWrapper.ADLXWrapper.Dispose()
   bei FanControl.ADLX.ADLXPlugin.Close()
   bei FanControl.Domain.ComputerAccessLayer.Close()
18.05.2024 09:57:33: ADLXWrapper.ADLXEception: Result: ADLX_ORPHAN_OBJECTS 
Couldn't terminate ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei ADLXWrapper.ADLXWrapper.Dispose()
   bei FanControl.ADLX.ADLXPlugin.Close()
   bei FanControl.Domain.ComputerAccessLayer.Close()
19.05.2024 09:44:41: ADLXWrapper.ADLXEception: Result: ADLX_ORPHAN_OBJECTS 
Couldn't terminate ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei ADLXWrapper.ADLXWrapper.Dispose()
   bei FanControl.ADLX.ADLXPlugin.Close()
   bei FanControl.Domain.ComputerAccessLayer.Close()
20.05.2024 10:10:02: ADLXWrapper.ADLXEception: Result: ADLX_ORPHAN_OBJECTS 
Couldn't terminate ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei ADLXWrapper.ADLXWrapper.Dispose()
   bei FanControl.ADLX.ADLXPlugin.Close()
   bei FanControl.Domain.ComputerAccessLayer.Close()

hmsta avatar May 21 '24 03:05 hmsta

What version of FanControl and are you using the latest build of the plugin?

Rem0o avatar May 21 '24 14:05 Rem0o

@Rem0o FanControl V191 (latest) and ADLX build from AppVeyor from 12. May (latest right now)

Thanks for the great work by the way.

hmsta avatar May 21 '24 14:05 hmsta

FanControl.zip I compiled a fix, replace your exe/dll with this one. Either net8 or 4.8, depending on the version you got.

Tell me if the problem occurs (or not) in the next few days.

Rem0o avatar May 21 '24 22:05 Rem0o

@Rem0o I've replaced the exe and downloaded the latest ddls from appveyor, which you've added today, and replaced all. I've just tested sleep mode and wakeup manually and it did not crash any more - so far. I'll keep an eye on it over the next few days and report back.

side note: under "To install" it says download from appveyor and "compile the solution" - so when I came here first I was confused what to do and if I could even use the plugin without any special build environment to compile it myself. I then went with the latest github release version, until I noticed the appveyor link contains ddl's too and seems way more recent. Maybe update the README for future noobs like me? :-)

Thank you

hmsta avatar May 22 '24 03:05 hmsta

unfortunately same error again this morning:

23.05.2024 09:22:34: ADLXWrapper.ADLXEception: Result: ADLX_ORPHAN_OBJECTS 
Couldn't terminate ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei ADLXWrapper.ADLXWrapper.Dispose()
   bei FanControl.ADLX.ADLXPlugin.Close()
   bei FanControl.Domain.ComputerAccessLayer.Close()

not exactly sure why that happens after being in sleep for a longer time - compared to yesterday, when no crash occurred, I tested sending to sleep and woke windows up like 30 seconds later. Maybe some timeouts while being asleep for 6+ hours terminate some other stuff it can't close then any more?

hmsta avatar May 23 '24 02:05 hmsta

sad update: keeps crashing with the same error, every morning I wake the PC up from sleep

hmsta avatar May 26 '24 03:05 hmsta

Sanity check, if you hit ctrl r in the app multiple times in a row, any error at all?

Rem0o avatar May 26 '24 03:05 Rem0o

Sanity check, if you hit ctrl r in the app multiple times in a row, any error at all?

only the the first time it crashed instantly with (had fancontrol started about an hour ago, after waking up the pc without finding it running)

26.05.2024 10:54:55: ADLX plugin: ADLXWrapper.ADLXEception: Result: ADLX_ALREADY_INITIALIZED 
Couldn't initialize ADLX
   bei ADLXWrapper.Extensions.ThrowIfError(ADLX_RESULT result, String message)
   bei FanControl.ADLX.ADLXPlugin.Initialize()

after restarting fancontrol I pressed ctrl r a few more times and no crash. I manually quit fancontrol a few more times, started, pressed ctrl r a few times. No crash.

hmsta avatar May 26 '24 03:05 hmsta

duplicate of #47 which seems to be more active :-)

hmsta avatar Jun 01 '24 05:06 hmsta