ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

fix/AB#106122_ABC-resource-question-display-glitches

Open unai-reliefapp opened this issue 1 year ago • 4 comments

Description

fix: initialize resource query on component mount, not on component open

Useful links

Type of change

Please delete options that are not relevant.

  • [X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • [ ] Test A
  • [ ] Test B

Screenshots

https://github.com/user-attachments/assets/f156a147-208a-41a4-8759-9ffadeeb64e7

We now initialize resource query on component mount, not on dropdown open

Checklist:

( * == Mandatory )

  • [X] * I have set myself as assignee of the pull request
  • [X] * My code follows the style guidelines of this project
  • [X] * Linting does not generate new warnings
  • [X] * I have performed a self-review of my own code
  • [X] * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • [X] * I have commented my code, particularly in hard-to-understand areas
  • [X] * I have put JSDoc comment in all required places
  • [X] * My changes generate no new warnings
  • [X] * I have included screenshots describing my changes if relevant
  • [X] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

unai-reliefapp avatar Nov 27 '24 14:11 unai-reliefapp

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e36d10085cb6f49382ec202132e9ab938b5891b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Nov 27 '24 14:11 nx-cloud[bot]

@unai-reliefapp

As shown in the video, you select the resource from the first page ( 10 first items of the query ) when you do that, the resource will automatically appear but if the selected resource is part of the 2nd page or any other page from the resources query, the item won't appear, even with these changes

AntoineRelief avatar Nov 29 '24 13:11 AntoineRelief

@unai-reliefapp putting back in todo as I don't think it solves the issue

AntoineRelief avatar Nov 29 '24 13:11 AntoineRelief

@AntoineRelief , last commit feat: remove unseful query subscription from the extended graphql component fix: update of values for outside of list elements in the resource dropdown for survey by always reassigning selected values from the list in the graphql component feat: improve the selectedResource property to avoid undefined trash values

https://github.com/user-attachments/assets/85115f3f-0c3c-4a4a-bec4-75bbfdcd29b7

unai-reliefapp avatar Nov 29 '24 15:11 unai-reliefapp