ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

Refactor/ab#82357 update angular fix memory leak issues and other fixes

Open unai-reliefapp opened this issue 2 years ago • 3 comments

Description

Fixed, among other minor issues:

  • fix most of the memory issues for unsubscribed values(some subscriptions are added on root services and cannot be unsubscribed until the app is closed) including unsubscribe flag for all widget settings forms, add missing subscription tear down for some observables
  • refactor many subscriptions within subscriptions to a single subscribe method in order to keep the code simple, effective and readable
  • fix all timeout listeners missing proper clear functions
  • fix required control label update from form wrapper when no label is set in the html
  • fix proper message sent on notification create/update/delete(duplication of same message and success message was send even if request failed)
  • fix correct role list fetch on list inside application and duplicate display message for add/delete role(duplication of same message and success message was send even if request failed)
  • fix property updates for resource and resources type questions in form builder, including search and add record button and table display and table buttons for resources

Useful links

Type of change

Please delete options that are not relevant.

  • [X] Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • [ ] Test A
  • [ ] Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • [x] * I have set myself as assignee of the pull request
  • [x] * My code follows the style guidelines of this project
  • [x] * Linting does not generate new warnings
  • [x] * I have performed a self-review of my own code
  • [x] * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • [x] * I have commented my code, particularly in hard-to-understand areas
  • [x] * I have put JSDoc comment in all required places
  • [x] * My changes generate no new warnings
  • [ ] * I have included screenshots describing my changes if relevant
  • [x] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

unai-reliefapp avatar Mar 04 '24 16:03 unai-reliefapp

@AntoineRelief Changes made set in the description and in the related ticket I think there is plenty to merge, next step I'll go to is to make an error handler service in order to avoid multiple error handlers everywhere, or missing ones, and keep a consistent error messaging logic across the app

KR, Unai

unai-reliefapp avatar Mar 06 '24 09:03 unai-reliefapp

@unai-reliefapp Nice Perhaps we should create separate branches ( even if they use the other ones ) so the PR is not becoming bigger

AntoineRelief avatar Mar 06 '24 09:03 AntoineRelief

@unai-reliefapp Nice Perhaps we should create separate branches ( even if they use the other ones ) so the PR is not becoming bigger

Yes, i'll create another branch for the error handler using same ticket number if it's okay

unai-reliefapp avatar Mar 06 '24 09:03 unai-reliefapp