ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

Fix/ab#81892 method for calc in utils parser

Open RenzoPrats opened this issue 2 years ago • 1 comments

Description

Fixed: Method for calc in utils parser is removing some span in the code.

Useful links

ticket

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested creating a text widget and putting some {{calc. operations inside the editor using some data to these operations that have style applied to the layout of it, and also testing if others span in the content is not being removed.

Screenshots

Peek 18-12-2023 16-40

Checklist:

( * == Mandatory )

  • [X] * I have set myself as assignee of the pull request
  • [X] * My code follows the style guidelines of this project
  • [X] * Linting does not generate new warnings
  • [X] * I have performed a self-review of my own code
  • [X] * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • [X] * I have commented my code, particularly in hard-to-understand areas
  • [X] * I have put JSDoc comment in all required places
  • [X] * My changes generate no new warnings
  • [X] * I have included screenshots describing my changes if relevant
  • [X] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

RenzoPrats avatar Dec 15 '23 20:12 RenzoPrats

@AntoineRelief is there the option were this values could be placed inside any other element besides span elements? If that the case a little modification should be done in the regex. Otherwise looks good 👍

unai-reliefapp avatar Dec 19 '23 08:12 unai-reliefapp