ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

Feat/ab#71073 add angular web worker integration for queries

Open unai-reliefapp opened this issue 2 years ago • 2 comments

⚠️ KEEP IT AS IT IS UNTIL SWITCHED BASE BRANCH TO THE NEW 2.0.X ⚠️

Description

Integration of the angular web worker package in order to use browser web worker services with an easy and angular friendly interface.

In order to achieve this, an @AngularWebWorker() class instance has been created with all the needed logic that we want the worker to handle plus also added a service that would handle all the requests from the application to the web worker client.

This worker service would be in charge of registering the worker client and detroying it, plus also contain all the needed methods to talk to the angular web worker class.

Worker client can be registered/destroyed at any time on demand.

Also updated back-office project.json with the webWorkerTsConfig property pointing to the related tsconfig file in order to recognize and make the new web workers work with the needed configuration for the package version and in Angular v15

Ticket

Link to ticket

Type of change

Please delete options that are not relevant.

  • [X] New feature (non-breaking change which adds functionality)
  • [X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • [ ] Test A
  • [ ] Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • [X] * The pull request is linked to an existing milestone
  • [X] * My code follows the style guidelines of this project
  • [X] * Linting does not generate new warnings
  • [X] * I have performed a self-review of my own code
  • [X] * I have commented my code, particularly in hard-to-understand areas
  • [X] * I have put JSDoc comment in all required places
  • [X] * My changes generate no new warnings
  • [X] * I have included screenshots describing my changes if relevant
  • [X] * I have selected labels in the Pull Request, according to the changes with code brings

unai-reliefapp avatar Jul 28 '23 15:07 unai-reliefapp

@unai-reliefapp putting this one on hold please add more information to the PR when you have some time

AntoineRelief avatar Aug 01 '23 09:08 AntoineRelief

@AntoineRelief Added some documentation regarding this PR plus switch base branch to the latest 2.0.x

KR, Unai

unai-reliefapp avatar Aug 01 '23 13:08 unai-reliefapp