ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

Bug/ab#69081 group layer visibility range not working

Open ValentinRLL opened this issue 2 years ago • 1 comments

Description

Sublayers have zoom range as well as group layers We need to display sublayers only if the current map zoom is inside the range of it group layer

I made sublayers zoom matching group zoom in case it's overlapping

Ticket

https://dev.azure.com/WHOHQ/EMSSAFE/_workitems/edit/69081

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I zoomed in and out to check if the sublayer is displaying outside it group range and it doesn't anymore.

Screenshots

image

image

Checklist:

( * == Mandatory )

  • [X] * My code follows the style guidelines of this project
  • [X] * Linting does not generate new warnings
  • [X] * I have performed a self-review of my own code
  • [X] * I have commented my code, particularly in hard-to-understand areas
  • [X] * I have put JSDoc comment in all required places
  • [X] * My changes generate no new warnings
  • [X] * I have included screenshots describing my changes if relevant
  • [X] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

ValentinRLL avatar Jul 13 '23 13:07 ValentinRLL

I also worked on it there: https://github.com/ReliefApplications/oort-frontend/pull/1715. Should this branch be closed @AntoineRelief ?

NathanHGit avatar Aug 16 '23 12:08 NathanHGit