RedMew icon indicating copy to clipboard operation
RedMew copied to clipboard

feat: Add blackfroest scenario

Open Bienenstock opened this issue 3 years ago • 3 comments

I hope there are no bugs left, I created this scenario a long time ago. Have Fun!

Bienenstock avatar Aug 08 '22 18:08 Bienenstock

Cool, thanks for making the PR.

I had a quick look and this mostly seems fine.

One thing I did notice is if I start the map with _DEBUG = true I get this error. image

I have a look tomorrow

Bienenstock avatar Aug 08 '22 20:08 Bienenstock

Cool, thanks for making the PR.

I had a quick look and this mostly seems fine.

One thing I did notice is if I start the map with _DEBUG = true I get this error.

fixed

Bienenstock avatar Aug 28 '22 02:08 Bienenstock

I have a bunch of patches but I can't commit them because git wants write permissions to someone elses repository.

@Bienenstock Here, before I throw my computer out the window:

Summary: add destroy_tree to create_particles to make leaf-particles, the way destroy_rock creates stone-particles, fix function description (create_particle, not create_entity)

refactor black_forest_grow: iterates every tree on the map, doesn't error on invalid entities any more, checks every tree and reduces redundant tree checks

general code quality cleaning, like using entity.destroy{raise_destroy = true}, instead of manual script raised destroy + an empty destroy().

changed_files.zip

jacobwatkinsgit avatar Aug 30 '22 22:08 jacobwatkinsgit