clowder icon indicating copy to clipboard operation
clowder copied to clipboard

RHCLOUD-36142: Update Clowder to reconcile on changes to non-app secrets/configmaps

Open nesty156 opened this issue 1 year ago • 6 comments

  • Add hashCache to the ClowdEnvironmentReconciliation
  • Remove all Secrets/ConfigMaps from Environment at start of reconciliation cycle
  • Embue HashObject with the always flag
  • Change updateHashCacheForConfigMapAndSecret to try to read in the sec/config and return true if always set
  • Make managed_kafka add the secret to the cache at the start of reconciliation
  • Update HashCache tests
  • Add kuttl tests for managed kafka secrets

cc: @psav

nesty156 avatar Jan 15 '25 17:01 nesty156

test-config-secret-restarter is broken working on fix now.

nesty156 avatar Jan 16 '25 10:01 nesty156

This is looking great so far, awesome work on this @nesty156 !

wcmitchell avatar Jan 17 '25 16:01 wcmitchell

e2e test fail: FAIL: kuttl/harness/test-clowdapp-watcher-kafka-msk (821.82s) There is issue in test-clowdapp-watcher-kafka-msk-sec-source namespace pod has this Error: test-clowdapp-watcher-kafka-msk-sec-source strimzi-topic-operator-59c597b8cb-scssl 0/1 CreateContainerConfigError 0 47s Namespace is terminating forever: test-clowdapp-watcher-kafka-msk-sec-source Terminating 6m5s

nesty156 avatar Feb 24 '25 15:02 nesty156

e2e test fail: FAIL: kuttl/harness/test-clowdapp-watcher-kafka-msk (821.82s) There is issue in test-clowdapp-watcher-kafka-msk-sec-source namespace pod has this Error: test-clowdapp-watcher-kafka-msk-sec-source strimzi-topic-operator-59c597b8cb-scssl 0/1 CreateContainerConfigError 0 47s Namespace is terminating forever: test-clowdapp-watcher-kafka-msk-sec-source Terminating 6m5s

FIXED with:

  • name: STRIMZI_USE_FINALIZERS value: 'false'

nesty156 avatar Feb 26 '25 15:02 nesty156

Seeing the unit test failure in TestMinio/createBucketsHitsCheckError, maybe due to missing config?

wcmitchell avatar Mar 25 '25 20:03 wcmitchell

/retest

wcmitchell avatar Mar 27 '25 16:03 wcmitchell

Did a deep dive into the code and everything looks good. I think we can move to get this rolled out. LGTM!

maknop avatar Jul 22 '25 20:07 maknop

/retest

maknop avatar Jul 24 '25 15:07 maknop