JStack icon indicating copy to clipboard operation
JStack copied to clipboard

Errors on PHP with Haxe 4.1/development

Open jonasmalacofilho opened this issue 5 years ago • 5 comments

This is probably related to HaxeFoundation/haxe#9124.

class Test {
	static function main() {
		throw 'Hi there';
	}
}
$ haxe -main Test -php test -lib jstack -D JSTACK_FORCE -D php7
haxe/std/php/_std/haxe/Exception.hx:79: characters 5-73 : Array<haxe.StackItem> should be Null<haxe.CallStack>
haxe/std/php/_std/haxe/Exception.hx:60: characters 27-44 : Class<haxe.CallStack> has no field exceptionToString
haxe/std/php/_std/haxe/Exception.hx:8: lines 8-83 : Field stack has different type than in core type
haxe/std/php/_std/haxe/Exception.hx:8: lines 8-83 : haxe.CallStack should be haxe.CallStack

jonasmalacofilho avatar Jun 26 '20 14:06 jonasmalacofilho

Hej !

Is there any news about haxe 4.1 compatibility please ?

filt3rek avatar Aug 16 '20 11:08 filt3rek

Not yet

RealyUniqueName avatar Aug 18 '20 08:08 RealyUniqueName

It requires major refactoring for 4.1 compatibility. I doubt I will have enough time to do it anytime soon.

RealyUniqueName avatar Aug 18 '20 08:08 RealyUniqueName

@filt3rek,

I can't work on it either, but see if maybe you can contribute the necessary fixes.

It's not a massive library, so you should be able to get up to speed pretty quickly. Then, of course, there's the refactoring @RealyUniqueName mentioned, but if you need this to work with 4.1 and you have some time, it's a worthwhile effort.

P.S. If you decide to pick this task, check with @RealyUniqueName how you should deal with backwards compatibility: can this be a new Haxe 4.1+ only version, or should it keep compatibility with Haxe 4.0 (or even 3.4)?

jonasmalacofilho avatar Aug 18 '20 15:08 jonasmalacofilho

Thanks guys !

I'll see if I have some time I'll try to make it work and then of course I'll suggest that to Aleksandr

filt3rek avatar Aug 18 '20 17:08 filt3rek