distributed-drl-coordination icon indicating copy to clipboard operation
distributed-drl-coordination copied to clipboard

Migration to SB3

Open katjamuench opened this issue 2 years ago • 4 comments

Are there plans to move this project to SB3 eventually?

katjamuench avatar Aug 24 '23 12:08 katjamuench

Hi @katjamuench , there are currently no plans of migrating. I only have time to respond to questions and fix minor bugs, but not for larger efforts or refactoring I am afraid.

If you or anyone else is willing to migrate, I would be happy to receive and review the PR.

stefanbschneider avatar Aug 30 '23 15:08 stefanbschneider

Hi @stefanbschneider . I have completed the migration of SB3 before, and all I need to do is download some software packages and modify some code changes to complete the migration. Do you need me to publish my code or create a branch? I am willing to provide assistance.

burnCalories avatar Sep 02 '23 03:09 burnCalories

I've also migrated it by now, however, I did need to modify the setup requirements for coord-sim and common-utils, though this seems to have made no significant impact on performance. I do have about a five percent decline in successful flows, but I assume that is because I've just tried using PPO with no parameters adjusted, since SB3 doesn't offer ACKTR.

katjamuench avatar Sep 02 '23 10:09 katjamuench

If you have a fork using SB3, I'd be happy to link it in the Readme!

Since @katjamuench reported that the results are a bit worse and there's no ACKTR in SB3, I'd rather keep this repo as is. It is supposed to represent the corresponding paper, where we produced all results with ACKTR.

stefanbschneider avatar Sep 04 '23 05:09 stefanbschneider