rxjs icon indicating copy to clipboard operation
rxjs copied to clipboard
verified publisher icon ReactiveX

fix(windowWhen): don't signal on complete

Open jakovljevic-mladen opened this issue 3 years ago • 2 comments

Description: This PR is split to two commits:

  • in the first, it aligns windowWhen with bufferWhen - it fixes a now considered bug, so that it stops accepting complete notifications from Observable emitted by closingSelector;
  • in another commit, it updates documentation and marble diagram:

Related issue (if exists): Closes #6876 Closes #6627

jakovljevic-mladen avatar Sep 01 '22 08:09 jakovljevic-mladen

Haven't reviewed yet, but I know the bug. It IS a bug, but the fix is also a breaking change. So we need to punt until next major.

benlesh avatar Sep 07 '22 20:09 benlesh

Switching to 8.x branch.

jakovljevic-mladen avatar Sep 09 '22 20:09 jakovljevic-mladen