rxjs icon indicating copy to clipboard operation
rxjs copied to clipboard

feat(delayWhen): `delayWhen`'s `delayDurationSelector` should support `ObservableInput`

Open jakovljevic-mladen opened this issue 3 years ago • 2 comments

Description: This PR adds support for delayWhen's delayDurationSelector to accept ObservableInput as a return type.

Since subscriptionDelay is deprecated, I didn't add support for ObservableInput for that parameter.

Related issue (if exists): Closes #7046

jakovljevic-mladen avatar Aug 29 '22 10:08 jakovljevic-mladen

Needs one test.

benlesh avatar Sep 07 '22 20:09 benlesh

@benlesh, tests added, please review them so I can continue converting other inner Observables to ObservableInputs.

jakovljevic-mladen avatar Sep 09 '22 21:09 jakovljevic-mladen

The added test may be a little slow. 1 ms per tick would have still done it. But it's fine, I guess.

benlesh avatar Sep 25 '22 19:09 benlesh

These are the same tests as these two audit tests.

jakovljevic-mladen avatar Sep 25 '22 19:09 jakovljevic-mladen

~I can create another PR to decrease the amount of time in all such tests.~

EDIT: Reviewed the entire repository, it seems that only audit is using interval(10) besides delayWhen from this PR. Fixed both of them in one go.

jakovljevic-mladen avatar Sep 25 '22 20:09 jakovljevic-mladen