core icon indicating copy to clipboard operation
core copied to clipboard

chore: add `TodoMVC` as example

Open Saviio opened this issue 7 years ago • 3 comments

这里还有一个分支: https://github.com/ReactiveDB/core/tree/chore/example-v2

我已经分不清哪个 branch 更值得推荐了...

我的主要问题在于,怎么写 dispatcher,视图组件的划分逻辑,要不要用 context

P.S. PR 的这个版本是使用了 context 的,建议 clone 下来 review

Saviio avatar Jan 21 '19 05:01 Saviio

Coverage Status

Coverage remained the same at 96.733% when pulling 7d959fc299bf10b97be8a9c601877e59fd2e1e8d on chore/example into 2311825633c79683cd26e26f4a77d42fb0559cbb on master.

coveralls avatar Jan 21 '19 05:01 coveralls

can't tell differences between both, imo, the context only injects code inside component, which make it as a more coupled component. besides, no differences to me.

mr-pinzhang avatar Jan 21 '19 06:01 mr-pinzhang

@Saviio really hard to cr, could you post key changes as a snippet image?

mr-pinzhang avatar Jan 21 '19 06:01 mr-pinzhang