ARC icon indicating copy to clipboard operation
ARC copied to clipboard

Fix missing path debug

Open amarkpayne opened this issue 5 years ago • 2 comments

I caught a typo in the messages the Arkane adapter returns when file paths are missing. While I was at it, I figured I would quickly refactor this code so that all missing file paths could be displayed if needed.

If you don't like the refactoring, I am fine with excluding all but the typo fix.

amarkpayne avatar May 12 '20 04:05 amarkpayne

Codecov Report

Merging #395 into master will not change coverage. The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          34       34           
  Lines       11904    11904           
  Branches     3633     3633           
=======================================
  Hits         6493     6493           
  Misses       4458     4458           
  Partials      953      953           
Impacted Files Coverage Δ
arc/statmech/arkane.py 67.87% <11.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e71a1a...41b109c. Read the comment docs.

codecov[bot] avatar May 12 '20 05:05 codecov[bot]

@amarkpayne, what is the status of this PR?

alongd avatar Jun 07 '20 00:06 alongd