revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: App Not Drawing Behind Navigation Bar on Patching Screen

Open Dan-Banfield opened this issue 2 years ago • 6 comments

Bug description

On the patching screen, it seems the app is not in edge-to-edge mode because it does not draw behind the system navigation bar.

1000020943

Version of ReVanced Manager and version & name of app you are patching

Version 1.19.3 App being patched: any

Installation method

Regular

ReVanced Manager logs

Not relevant.

Patch logs

Not relevant.

Acknowledgements

  • [X] This issue is not a duplicate of an existing bug report.
  • [X] I have chosen an appropriate title.
  • [X] All requested information has been provided properly.
  • [X] The bug is only related to ReVanced Manager

Dan-Banfield avatar Mar 24 '24 11:03 Dan-Banfield

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

snehithssv avatar Jun 11 '24 06:06 snehithssv

So, while on patching screen, the bottom nav-bar should be hidden?? @Dan-Banfield

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

Dan-Banfield avatar Jun 11 '24 07:06 Dan-Banfield

No, not hidden, just the app should draw behind it in-line for the upcoming mandate in Android 15.

So, app is to be forced to be in edgeToEdge instead of leanBack/immersive.? More like this...?? Screenshot_1718089769

And if yes, should it be this way only in patch screen on for the whole application??

snehithssv avatar Jun 11 '24 07:06 snehithssv

In the screenshot you provided, the navigation bar at the bottom is still black. Instead, it should be drawn behind. Please see: https://developer.android.com/about/versions/15/behavior-changes-15#:~:text=Edge-to-edge%20enforcement,because%20most%20components%20apply%20insets.

Dan-Banfield avatar Jun 11 '24 11:06 Dan-Banfield

Thanks a lot for helping me out... @Dan-Banfield projc.webm So, is this the desired functionality?

snehithssv avatar Jun 12 '24 06:06 snehithssv

Thanks a lot for helping me out... @Dan-Banfield projc.webm So, is this the desired functionality?

Yes, that looks great! Nice job.

Dan-Banfield avatar Jun 12 '24 06:06 Dan-Banfield

This can be closed right?

This can be closed right?

Nice catch, thanks.

validcube avatar Feb 11 '25 12:02 validcube