revanced-cli icon indicating copy to clipboard operation
revanced-cli copied to clipboard

problem: listing patches requires input apk again

Open l4v3nx opened this issue 3 years ago • 8 comments

🐞 Issue

i wanna look at the changes in patches file (to include/exclude new patches), but cli gives me an error Error: Missing required argument(s): --apk=<inputFile>

⚙ Reproduce

i use revanced aur package. command: revanced-cli (just alias to java -jar /usr/share/revanced/revanced-cli.jar) -b /usr/share/revanced/revanced-patches.jar -l

🛠 Solution

selecting vanilla youtube input apk is the solution

⚠ Additional context

l4v3nx avatar Jul 10 '22 15:07 l4v3nx

Wrong usage. -a youtube.apk is missing.

TheJeterLP avatar Jul 10 '22 15:07 TheJeterLP

this is definitely a regression

bogadana avatar Jul 10 '22 15:07 bogadana

but i could list patches without youtube.apk before

l4v3nx avatar Jul 10 '22 15:07 l4v3nx

introduced here https://github.com/revanced/revanced-cli/commit/131100ef0043924a9c11eb9886b4f6b0373690d9

bogadana avatar Jul 10 '22 15:07 bogadana

@Itroublve also --uninstall argument need input apk. why program have to use file on pc to uninstall youtube on phone? i don't think it should work this way

l4v3nx avatar Jul 10 '22 18:07 l4v3nx

Just to add my findings here that no one would care: The -a flag for the listing apparently will not care what you're passing, so something like java -jar CLI.jar -a NeverGonnaGiveYouUp -b Patches.jar -l still works...

shrihankp avatar Jul 15 '22 09:07 shrihankp