ReClass.NET icon indicating copy to clipboard operation
ReClass.NET copied to clipboard

Add setting for optional zip compression (different approach)

Open DisabledMallis opened this issue 3 years ago • 0 comments

I know someone already opened a PR for this feature, however I decided to try implementing it a little differently on my fork. Instead of modifying the ReClassNetFile class(es), I decided to create a new one called ReClassDataFile. Enabling/Disabling the "Compress as ZIP" under a new "Project Settings" tab will enable/disable the use of ReClassDataFile over ReClassNetFile. The benefit of using a new class to implement the feature is that it continues to follow the current code format/style, whereas just modifying the ReClassNetFile class directly could encourage code to become a little 'messy'.

There are some more things I should probably fix/change to make this a better suited PR for merging, such as:

  • Just putting "Compress as ZIP" under "General" instead of "Project Settings". I think it would be better to have a general project-specific settings tab, but that may not be the case.
  • Opening a rcnet or xml file should adjust the setting accordingly.

DisabledMallis avatar Nov 08 '22 14:11 DisabledMallis