java-xirr icon indicating copy to clipboard operation
java-xirr copied to clipboard

Support different day per year standards

Open darenwatkins opened this issue 2 years ago • 2 comments

At the moment only actual over 365 is supported, but many contracts specify actual over 360. It should be possible to override the default value, and specify a custom number of days per year. I'll raise a PR and include a test case

darenwatkins avatar Nov 26 '23 15:11 darenwatkins

I look forward to seeing your PR.

On Sun, Nov 26, 2023, 9:33 AM Daren @.***> wrote:

At the moment only actual over 365 is supported, but many contracts specify actual over 360. It should be possible to override the default value, and specify a custom number of days per year. I'll raise a PR and include a test case

— Reply to this email directly, view it on GitHub https://github.com/RayDeCampo/java-xirr/issues/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQWO23NLPFLCWIKX7Y4E6DYGNON5AVCNFSM6AAAAAA7252TVCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTCMBYGY4DGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RayDeCampo avatar Nov 28 '23 16:11 RayDeCampo

Hi Ray, I have now raised a PR. Thanks

darenwatkins avatar Dec 01 '23 11:12 darenwatkins

See https://github.com/RayDeCampo/java-xirr/pull/33

RayDeCampo avatar Apr 13 '24 20:04 RayDeCampo