SkillDisplay icon indicating copy to clipboard operation
SkillDisplay copied to clipboard

feat: Add Sprint

Open reyronald opened this issue 2 years ago • 3 comments

image

Hi, first of all, thank you for this amazing plugin. I love it, use it all the time and find it extremely useful!

While reviewing some VODs I noticed that Sprint was not showing. I noticed it's because it is not categorized as a combat action so I added a little exception just for it. Although it is true that's not specifically for combat, certain raid mechanic benefit a lot from its usage and given that this is mostly an educational tool I feel it would be helpful to have it displayed.

Let me know if you're okay with this change or if you'd like a different approach.

Thanks again!

https://xivapi.com/Action/3?columns=Icon,Name,ActionCategoryTargetID https://xivapi.com/i/000000/000405.png https://xivapi.com/i/000000/000104.png

reyronald avatar Dec 30 '23 19:12 reyronald

This is awesome. Do you know if something can be done for pots as well? With that said, this project doesn't seem to be maintained anymore :(

Edit: For pots, looks like the action ID changes every patch even for the same item.

HaySome22 avatar Jan 15 '24 19:01 HaySome22

Hey @HaySome22, thanks!

I actually already added pots to my fork, was just waiting to get attention on this PR before submitting a new one.

My fork is also hosted so feel free to use it instead. Let me know if it works for you

  • https://reyronald.github.io/SkillDisplay/
  • https://reyronald.github.io/SkillDisplay/?HOST_PORT=ws://127.0.0.1:10501

image

reyronald avatar Jan 16 '24 23:01 reyronald

Nice, your fork works!

HaySome22 avatar Jan 17 '24 14:01 HaySome22