Ravencoin icon indicating copy to clipboard operation
Ravencoin copied to clipboard

consensus: adjust bip9 periods

Open fdoving opened this issue 4 years ago • 4 comments

10x the default counting periods. Previous period was 2016 blocks or about 1.4 day. Proposed period is 20160 blocks or about 14 days.

  • The LOCKED_IN period is extended from 1.4 to 14 days, during which non upgraded nodes will be warned of the upcoming fork.
  • 10 times as expensive to potentially try to force activation with rented hashpower.
  • Slower activation. Previous minimum activation time from counting starts, about 3 days, with this proposal about 30 days.

fdoving avatar Nov 07 '21 09:11 fdoving

I suggest to change the confirmation window, not only for P2SH assets, as an override, but as a feature for all changes to mainnet.

fdoving avatar Nov 07 '21 09:11 fdoving

You can't change the defaults. They need to stay the same because otherwise as the code is syncing it will be expecting different times for all previous hardforks (DGW, etc). Just do the overrides. The code would work for anyone just upgrading, but break for new users that sync the chain from scratch.

TronBlack avatar Jan 17 '22 22:01 TronBlack

You can't change the defaults. They need to stay the same because otherwise as the code is syncing it will be expecting different times for all previous hardforks (DGW, etc). Just do the overrides. The code would work for anyone just upgrading, but break for new users that sync the chain from scratch.

Fixed.

fdoving avatar Jan 18 '22 12:01 fdoving

Approved as modified to just the overrides.

It would make sense to run this change against the main chain before and after BIP9 activation.

A force of the BIP9 activation (in code) could be done, then a full chain sync. It should continue to run as long as no P2SH (or other BIP9 wrapped transactions are published).

I think it makes sense to have a longer activation threshold this time around. If we've agreed that all future ones should also be longer, then a comment around where the activation threshold override gets set should suffice, so that future threshold overrides are also set to 10x.

TronBlack avatar Feb 18 '22 00:02 TronBlack