Andrey Savchenko

> I think if we use reach and range, the need of that field goes away? I think that's less of a rules question and more of API design question...

For trivia there are no longer any supported HHVM versions that support PHP code, the last one was [3.30 supported until November 2019](https://hhvm.com/blog/2018/12/17/hhvm-3.30.html). They went entirely Hack since, so there...

Hey, I am otherwise occupied at the moment (there is still the war going), so not ignoring it, but no promises when will I get to catching up on pull...

No, I think I just kept the rules in the stylesheet at the time.

(Repeating some of my thoughts from slack on request) In my opinion the easy way to write that example would be: ```php do_action( 'upgrader_process_complete', $this, array( 'action' => 'update', 'type'...

Yes, `while` and `do while` should behave same according to spec. More granular with PRs, please. I'd rather deal with small focused ones, since this is not a code I...

Think the issue is that PHP CS tokenizer considers `case ` a level and cognitive complexity doesn't. So stuff within case gets extra +1 from nesting each, as level is...

1. Still unrelated code style changes, only what matters for the fix, pretty please. 2. I don't follow the need to switch to file object, it doesn't seem to be...

> PHP_CodeSniffer\Files\File object is also utilized in is IncrementingToken Ah, must have missed that. Checked branch as is now. 1. Why does it change phpunit.xml ? That causes warning too:...

Gotcha, are you trying to run with PHPUnit 9? Scrutinizer is still set up against 8, so I am running with that locally as well. Can be updated at some...