kubesess icon indicating copy to clipboard operation
kubesess copied to clipboard

[Fix] - Kubeconfig merge needs user and cluster

Open Ramilito opened this issue 2 years ago • 2 comments

Description

When merging and not using kubeconfig env variable, the resulting cached files don't have cluster and user in them. This PR adds those so they can be more complete. Results: default

Fixes # (issue) #46 Fixes part of this

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Tested locally by using it for a while

Ramilito avatar Feb 10 '24 20:02 Ramilito

Hi, thanks for adding me as a reviewer 😊 I'm quite busy this week but I'll have a look this Saturday!

nicmr avatar Feb 14 '24 20:02 nicmr

Ive been running with this for a while and only noticed one issue, the kcd command doesn't permanently set it, I'm guessing it's because the merged files isn't known to kubectl. Will try setting the --kubeconfig command dynamically and see if it helps

Ramilito avatar Mar 07 '24 07:03 Ramilito

This isn't needed anymore thanks to this: #60

Ramilito avatar Oct 19 '24 12:10 Ramilito