hcc SWDEV-221755 - Re-implement deprecated HSAQueue::copy

Revert "remove deprecated HSAQueue::copy_ext due to inf recursion" This reverts commit 5cd096ae42277d36d123c827fd8981de288f07a8 and 4ee361270f5938e34b0759c21f59cdcd0a99b021. This change causes a regression on GFX908 for BFloat16 tuning on MIOpen.

Mar 24 '20 21:03 aaronenyeshi

If we weren't experiencing inf recursion before from this API, I doubt it will happen now once we revert the previous commit(s). If this weren't a pressing matter, I would prefer we understand how removing a deprecated API caused a regression.

Mar 24 '20 22:03 jeffdaily

I am not sure why the tests are failing to find hsa-runtime library: /home/jenkins/workspace/iopen-bf16-mi100-regression-KY7AW7RBQG5VFEYPD232GW5Q2TTVVKROSFDNS3OQGXZO52APJDZQ/build/release/tests/Unit/AcceleratorViewCopy/Output/avcopy_classic.cpp.tmp.out: error while loading shared libraries: libhsa-runtime64.so.1: cannot open shared object file: No such file or directory

Mar 25 '20 18:03 aaronenyeshi

On my system, it all passed:

root@6bb76b9f30fc:~/hcc/build# make test
Running HCC regression tests
llvm-lit: /root/hcc/tests/lit.cfg:116: note: using clang: '/root/hcc/build/llvm-project/llvm/bin/clang'

Testing Time: 479.72s
  Expected Passes    : 670
  Expected Failures  : 44
Built target test

Mar 26 '20 19:03 aaronenyeshi

Closing old prs

Feb 15 '24 16:02 aaronenyeshi

SWDEV-221755 - Re-implement deprecated HSAQueue::copy_ext