ROCT-Thunk-Interface icon indicating copy to clipboard operation
ROCT-Thunk-Interface copied to clipboard
verified publisher icon RadeonOpenCompute

Why look for libudev?

Open haampie opened this issue 3 years ago • 2 comments

Any particular reason why

https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/3277d5354ed623598a5cea82cc3790a577af177c/CMakeLists.txt#L195

this was added to ROCm 4.5.0? (pinging @kentrussell)

I don't see it being used in the code at all.

It blocks automated builds of this package as reported for instance here https://github.com/spack/spack/issues/28398

haampie avatar Feb 08 '22 18:02 haampie

This is a remnant of some old requirements (https://github.com/RadeonOpenCompute/rocminfo/issues/9). With a static thunk and with packaging being more fleshed out, we can remove this requirement.

I have made a change internally and it should be out for our next release (removing zlib and libudev requirements). Thanks for bringing this to our attention!

kentrussell avatar Feb 10 '22 14:02 kentrussell

Thanks a lot!

haampie avatar Feb 10 '22 18:02 haampie

Sorry for leaving this open so long. Removed as of ROCm 5.3

kentrussell avatar Feb 24 '23 17:02 kentrussell