ROCT-Thunk-Interface icon indicating copy to clipboard operation
ROCT-Thunk-Interface copied to clipboard

Fix GPU cache size unit from KiB to B

Open kazuki opened this issue 8 years ago • 3 comments

kazuki avatar Jul 12 '17 15:07 kazuki

I'm checking with the owner of the Thunk specification what unit we should be reporting.

fxkamd avatar Jul 12 '17 20:07 fxkamd

Thanks.

Currently, ROCR's hsa_cache_get_info(HSA_CACHE_INFO_SIZE) returns size in byte unit in cpu agent but returns size in KiB unit in gpu agent.

Maybe, ROCT interface returns size in KiB unit. And to fix above problem, fix ROCT/ROCR, to ROCT returns cpu cache size in KiB unit and ROCR returns cpu/gpu cache size in byte unit.

kazuki avatar Jul 12 '17 23:07 kazuki

@fxkamd Did we ever get a response on this?

kentrussell avatar Mar 12 '19 12:03 kentrussell

This was resolved in ROCr in ROCm 4.3 (502dc3a9c99dc Get GPU cache information from KFD) EDIT: We can't change this without breaking backwards-compatibility. And ROCr successfully handles it now so it's being closed for that reason.

kentrussell avatar Feb 24 '23 21:02 kentrussell