Fixing non-portable inline attribute on hsa_flag_* utilities.

Open benvanik opened this issue 1 year ago • 3 comments

Not all compilers support the __attribute__ syntax and those that do may not support always_inline. This changes to just using inline on the simple flag functions as they are likely to be inlined anyway. Fixes MSVC builds.

Oct 27 '24 16:10 benvanik

I vote for removing the attribute from this file altogether. But I'll defer to @dayatsin-amd's opinion here.

Oct 28 '24 19:10 atgutier

I vote for removing the attribute from this file altogether. But I'll defer to @dayatsin-amd's opinion here.

This is aligned with our goal of having ROCR on windows OS

Oct 28 '24 20:10 dezhiAmd

Simplified to just removing the attribute and using the C inline keyword. PTAL!

Oct 29 '24 13:10 benvanik