ROCR-Runtime icon indicating copy to clipboard operation
ROCR-Runtime copied to clipboard

LICENSE file is missing MIT license

Open Artem-B opened this issue 5 years ago • 3 comments

https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/8ea15e12ee4760dc6ec394841a5de8e8b9e8c845/LICENSE.txt#L1

Some of the source files in the repo appear to be under MIT license (e.g. https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/master/src/image/addrlib/inc/addrinterface.h) which is currently not included in the LICENSE.txt.

Artem-B avatar Aug 25 '20 21:08 Artem-B

Hi, thanks for the observation. Unfortunately it is something we are unable to change, per advise from legal department.

rerrabolu avatar Aug 25 '20 23:08 rerrabolu

Hi @Artem-B. Are you expecting license.txt to hold all licenses used in the project? A kind of license directory of sorts? All files (where possible/practical) should already have their respective license at the top of the file. Thanks.

skeelyamd avatar Aug 26 '20 22:08 skeelyamd

@rerrabolu: It was not clear if that was done deliberately or not. If you're following your counsel's advice, then that's their call.

@skeelyamd Something like that. Including all used licenses in the top-level of the project makes it easy to see all the requirements up-front without having to check every file in the repo in order to know what users will need to comply with if they want to use it. Not everyone has robust automatic license checking in place for every project they import from github and having to check all files is rather burdensome for nontrivial projects.

Artem-B avatar Aug 30 '20 20:08 Artem-B