Radarr icon indicating copy to clipboard operation
Radarr copied to clipboard

WIP: Add IPv6 override for http client

Open covert8 opened this issue 2 years ago • 3 comments

Database Migration

NO

Description

It's goal is to allow an override for unstable IPv6 only environments like k8s.

Screenshot (if UI related)

Todos

  • [ ] Tests
  • [ ] Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • [ ] Wiki Updates

Issues Fixed or Closed by this PR

  • Fixes #7637

covert8 avatar Dec 13 '23 21:12 covert8

@markus101 upstream thoughts? @covert8 this is something that should be upstream in sonarr and then aligned and pulled downstream

cc @Qstick for thoughts

bakerboy448 avatar Dec 13 '23 21:12 bakerboy448

Thanks for the heads-up, still interested if this is the way to approach this.

Copying what I said the in issue

Happy eyeballs will supposedly be added in 9.0 of dotnet https://github.com/dotnet/runtime/issues/87932

covert8 avatar Dec 13 '23 21:12 covert8

I agree that the current solution of globally disabling IPv6 when one failure occurs isn't ideal, but I don't think it makes sense to have a configuration setting to force IPv6.

If we want to continue to disable it globally then we should periodically retry, maybe via a cached value with a timeout or consider moving it to a domain-based cache where different domains can have independent values for IPv6 support. This would mean users that have bad IPv6 setups would take a little longer to make connections, but people with things configured properly it'd work a lot better.

markus101 avatar Dec 31 '23 17:12 markus101