Clean library tag
This is a PR to replace: https://github.com/Radarr/Radarr/pull/6723
Hi, thanks for the PR.
This looks outdated just looking at the UI changes and not in line with upstream at all. Have you tested these changes to be certain it's functionality is as advertised?
Hi, thanks for the PR.
This looks outdated just looking at the UI changes and not in line with upstream at all. Have you tested these changes to be certain it's functionality is as advertised?
I just tested now.. and it works as intended... but maybe I need to describe the feature more appropriately:
With that tag set..
Now whenever netImportSync task is performed any movies that are in the radarr library that are not found in the netImportListSync will be tagged with that tag..
the Cleanlibrary customfilter can be set as follows:
Again it works.. I implemented this in my private fork a long time ago.. so yes, the code may not fit with how things are now.. but it does in fact work.. i can spend some time refactoring code if you have any suggestions.. i implemented 4 years ago.. so i apologize if its not in perfect shape.
I will look into 2 things:
- refactor and simplify code to match modern code.
- update/create the tags tests which will now need to take into account isCleanLibraryTag checks etc...
Also the commit with the forceSyncImportLists doesn't necessarily need to be merged as part of this feature (although, I think a simple way to force ImportSync is a good idea)... its just that it was a pain to test/implement this if the importSync didnt always happen even when you manually trigger it...... IMO when you manually trigger it, it should happen regardless of when it last was done.. but thats just my opinion.. and that commit isn't necessarily within the scope of this feature..