dxa-web-application-java icon indicating copy to clipboard operation
dxa-web-application-java copied to clipboard
verified publisher icon RWS

fix for issue #86 - Possible classpath scanning issues by using XPathFactory.newInstance()

Open dfranssen opened this issue 8 years ago • 1 comments

fixes #86 - Possible classpath scanning issues by using XPathFactory.newInstance()

dfranssen avatar Dec 08 '17 09:12 dfranssen

This PR solves actually solves two things:

  • The classpath scanning issues is prevented by avoiding XPathFactory.newInstance()
  • The DefaultRichTextProcessor no longer uses the XPathResolver which is not thread-safe.

The DefaultRichTextProcessor is now using the new thread-safe and classpath-scanning-proof XPathExpressionResolver instead of the XPathResolver. The XPathResolver should be avoided and is marked as deprecated.

The code in this PR is undergoing load testing and endurance testing on a DXA 1.5 based production environment. I think it is pretty solid :)

jhorsman avatar Dec 08 '17 14:12 jhorsman