dxa-web-application-dotnet icon indicating copy to clipboard operation
dxa-web-application-dotnet copied to clipboard

Web-Install.ps1 stops on relative path in -distDestination parameter

Open jhorsman opened this issue 9 years ago • 1 comments

When calling web-install.ps1 with a relative path in the -distDestination parameter, the script will raise an error upon saving the Log.config.

For example web-install.ps1 -distDestination ..\..\test

This can simply be prevented by making sure the path is resolved with Resolve-Path before using it.

#Terminate script on first occurred exception
$ErrorActionPreference = "Stop"

$distDestination = Resolve-Path -Path $distDestination

#Process 'WhatIf' and 'Confirm' options
if (!($pscmdlet.ShouldProcess($distDestination, "Deploy DXA .NET Web Application"))) { return }

I would love to do a PR for this, but if I am not mistaken the installation scripts like web-install.ps1 is not in any of the Github repos.

jhorsman avatar May 01 '17 20:05 jhorsman

Internal Issue ID (for tracking purposes): CRQ-12791

rpannekoek avatar Dec 17 '18 16:12 rpannekoek