pinnacle icon indicating copy to clipboard operation
pinnacle copied to clipboard

Indicators + Other bug fixes

Open CatsLover2006 opened this issue 11 months ago • 7 comments

This is basically me implementing #7. Currently it only has grabbers, but I plan to implement app previews at a later date (hence the comment in the prefs and the TODO). Animation is kinda scuffed (it's just a fade) but it works.

Also adds in the ability to open stacks from either side, as another option within the preferences.

Only caveat is that I have only been able to test on my iOS 16.6.1 iPhone 11 Pro with NathanLR. I don't think this should cause issues (if anything I'd expect NathanLR to cause compatibility issues), but you might want to confirm it works on other iOS 16 versions and especially iOS 15. I don't currently have access to my iOS 16.4.1 iPhone SE 2, and I don't own a single device running iOS 15.

CatsLover2006 avatar Mar 09 '25 06:03 CatsLover2006

Wow, I appreciate the pr. When I get some time i'll review it, make any changes need it, and merge. Thank you so much :)

RUGMJ avatar Mar 16 '25 17:03 RUGMJ

Gosh, glad you caught 20f9e69, i probably would've been very confused when testing before release

RUGMJ avatar Mar 16 '25 17:03 RUGMJ

Note that the build has a bunch of warnings about unused variables in the indicator update function, all of which pertain to direction of an icon. I plan to use them when I eventually implement app previews, but I'm also knee deep in uni courses and am fairly new to tweak development (especially in Swift), so that might take a while

CatsLover2006 avatar Mar 17 '25 03:03 CatsLover2006

I've now tested this using my iOS 16.4.1 iPhone SE 2 and tracked down the folder crash bug. In future I'm going to use it for testing as it gives me more useful crash information than my 16.6.1 iPhone 11 Pro. I might also look into buying an iPhone 6S or 7 (or their plus variants) to test on.

CatsLover2006 avatar May 10 '25 06:05 CatsLover2006

Awesome, in a few weeks i'll be finished with exams and will be able to test this pr properly :)

RUGMJ avatar May 18 '25 14:05 RUGMJ

I hope your exams are done by now

CatsLover2006 avatar Aug 27 '25 17:08 CatsLover2006

I recently (and by recently I mean 3 hours ago) acquired an iPhone XR running iOS 15.6.1, and was able to test my updates to the tweak on iOS 15.

CatsLover2006 avatar Nov 14 '25 04:11 CatsLover2006