rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

rt_size_t/rt_err_t 混用

Open foldl opened this issue 3 years ago • 7 comments

rt_spi_transfer 为例:

rt_size_t rt_spi_transfer(struct rt_spi_device *device,
                          const void           *send_buf,
                          void                 *recv_buf,
                          rt_size_t             length)
{
    rt_err_t result;

    //...

    result = device->bus->ops->xfer(device, &message);

    // ....  
    return result;
}

foldl avatar Jul 08 '22 02:07 foldl

某些场合,这俩是可以混用的。正数代表正常长度值。0 代表空或0长度,负数代表错误。

thewon86 avatar Jul 08 '22 06:07 thewon86

rt_size_t 是无符号的。虽然嵌入式里长度可能到不了 0x7fffffff,但还是严格一些好。

foldl avatar Jul 08 '22 07:07 foldl

是,这里不能用无符号

thewon86 avatar Jul 08 '22 07:07 thewon86

是的 这里非常的不规范 感谢反馈

mysterywolf avatar Jul 10 '22 19:07 mysterywolf

https://github.com/RTduino/RTduino/pull/19

mysterywolf avatar Jul 22 '22 14:07 mysterywolf

除了SPI,I2C也有同样的问题,软件SPI也要确认一下

mysterywolf avatar Aug 02 '22 01:08 mysterywolf

PR已经提交

xiangxistu avatar Aug 02 '22 06:08 xiangxistu