rt-thread
rt-thread copied to clipboard
[DeviceDriver] Fix can infinite loop when can driver send error
拉取/合并请求描述:(PR description)
[
- in _can_int_tx if can driver sendmsg do not return RT_EOK, it will repeat until sendmsg return RT_EOK
- if error occur on can bus(wire broken or EMI), all threads that have lower priority will not be executed
- we should let application layer to determine if resend is appropriate when send fail, besides in data link layer, can already implemented auto resend in hardware
- CAN总线产生错误,或者短线的情况下,_can_int_tx 会陷入无限循环
- 通常 CAN 发送线程的优先级会比较高,比如为了实时控制电机,这样就会导致比它优先级低的所有线程得不到执行
- CAN 总线消息重发应交给应用层执行,底层数据链路层有自动重发,在驱动中再加一个自动重发没有必要
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。 The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
- [x] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
- [ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
- [x] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
- [ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
- [ ] 没有垃圾代码,代码尽量精简,不包含
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up - [ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
- [ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
- [ ] 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
- [ ] 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
related: https://github.com/RT-Thread/rt-thread/issues/4981