fix(desktop): handle duration_in_seconds correctly in timestamp

[kovsu]

Before	After

[follow-reviewer-bot[bot]]

Thank you for your contribution. We will review it promptly.

[vercel[bot]]

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

[follow-reviewer-bot[bot]]

Suggested PR Title:

fix(TimeStamp): format media duration from string to number

Change Summary: Updated TimeStamp component to format media duration correctly when it is a string representation of a number. This resolves potential type issues and ensures accurate handling of media duration.

Code Review:

Code Review: Change Requests

apps/desktop/src/renderer/src/modules/renderer/components/TimeStamp.tsx

1. Line 11:

   • Issue: The formatTimeToSeconds function is being used, but there is no validation to ensure the input type matches what the function expects. While there is a comment indicating the type mismatch (@ts-expect-error durationInSeconds is string), it does not seem ideal to rely on a TypeScript error suppression for this logic. If duration_in_seconds is a string but contains invalid content (e.g., non-numeric characters), formatTimeToSeconds might fail unexpectedly or produce incorrect results.
   • Change Request: Consider adding validation or type-checking logic before calling formatTimeToSeconds. For example, ensure the string represents a valid time format or numeric value.

2. Line 12:

   • Issue: Suppressing TypeScript errors with @ts-expect-error should generally be avoided unless absolutely necessary. Instead, the code should resolve any type mismatch explicitly, such as by ensuring the type of duration_in_seconds is correct upstream where the data is being fetched or processed. Suppressing errors can lead to unexpected runtime issues and reduce maintainability.
   • Change Request: Resolve the type mismatch by fixing the type definitions for duration_in_seconds in the corresponding type interface or schema, ensuring TypeScript correctly infers the data type.

---

Addressing these issues will improve the reliability and maintainability of the code.

[follow-reviewer-bot[bot]]

Thank you for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪