rss-bridge icon indicating copy to clipboard operation
rss-bridge copied to clipboard

[OLXBridge] new bridge

Open wrobelda opened this issue 3 years ago • 10 comments

Adds new bridge for the OLX classifieds platform. Should support all international favors of it.

Based on https://github.com/MK-PL/OLX-RSS by Maciej Kawa.

wrobelda avatar Jul 29 '22 14:07 wrobelda

Pull request artifacts

file last change
OLXBridge-pr-context1 2022-11-17, 08:54:29

github-actions[bot] avatar Jul 29 '22 14:07 github-actions[bot]

Works but takes like 20s. Also lots of php notices.

dvikan avatar Jul 31 '22 03:07 dvikan

Works but takes like 20s.

Only the first run, though, subsequent runs will be much faster with getSimpleHTMLDOMCached hitting the cache.

Also lots of php notices.

Let me look into that.

wrobelda avatar Jul 31 '22 08:07 wrobelda

Also lots of php notices.

Now fixed, thanks.

wrobelda avatar Jul 31 '22 08:07 wrobelda

Hi,

I just tested the other languages that OLX provides and none of them work.

https://www.olx.ro/piese-auto/mecanica-electrica/q-toyota/ https://www.olx.com.br/brasil?q=toyota https://www.olx.co.id/items/q-toyota https://www.olx.pt/ads/q-toyota/ https://www.olx.in/items/q-toyota?isSearchCall=true

The only one that works is the polish version. Also, most of those sites look very different, so the css cant work.

Bockiii avatar Aug 12 '22 13:08 Bockiii

I tested the Romanian version during the development and it did absolutely work just fine... Let me check again.

wrobelda avatar Aug 12 '22 13:08 wrobelda

The problem with your European OLX examples is the trailing slash — updated the code to remove it. The other OLX websites are indeed incompatible, I will therefore explicitly whitelist those that are. Thanks for testing!

wrobelda avatar Aug 12 '22 14:08 wrobelda

@wrobelda so?

Bockiii avatar Aug 24 '22 12:08 Bockiii

I need to add some filter on domain part of the URL. Any existing bridges that do something similar?

wrobelda avatar Aug 24 '22 12:08 wrobelda

You can use input patterns that only allow your chosen .tld

https://github.com/RSS-Bridge/rss-bridge/blob/master/bridges/GoodreadsBridge.php#L21

Bockiii avatar Aug 24 '22 13:08 Bockiii

@Bockiii this is now ready, please review again.

EDIT: actually, I have some improvement in works, I'll ping back when done.

wrobelda avatar Oct 05 '22 16:10 wrobelda

@Bockiii should be ready now

wrobelda avatar Oct 06 '22 12:10 wrobelda

@dvikan this is ready now, notices should not happen anymore

wrobelda avatar Oct 06 '22 12:10 wrobelda

This branch has conflicts that must be resolved

dvikan avatar Nov 17 '22 04:11 dvikan

This branch has conflicts that must be resolved

Done

wrobelda avatar Nov 17 '22 08:11 wrobelda