MachineState icon indicating copy to clipboard operation
MachineState copied to clipboard

Add class for AMD ROCm devices

Open TomTheBear opened this issue 4 years ago • 3 comments

TomTheBear avatar Mar 15 '21 15:03 TomTheBear

Codecov Report

Merging #19 (57e0be9) into master (dd83ad7) will decrease coverage by 1.63%. The diff coverage is 19.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   87.14%   85.51%   -1.64%     
==========================================
  Files          14       14              
  Lines        3772     3865      +93     
==========================================
+ Hits         3287     3305      +18     
- Misses        485      560      +75     
Impacted Files Coverage Δ
machinestate.py 76.89% <19.35%> (-2.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd83ad7...57e0be9. Read the comment docs.

codecov-io avatar Mar 15 '21 15:03 codecov-io

I have not found a way to get the version of the installed ROCm stack. My test machine has version 4.4.x installed but I'm not getting these numbers anywhere. My attempts where:

$ strings -a /opt/rocm/lib/libhsa-runtime64.so | grep "ROCR BUILD ID"
ROCR BUILD ID: 1.2.40001.0-rocm-rel-4.0-26-a5173c90
$ /opt/rocm/bin/hipconfig | grep -i version HIP version  : 4.0.20496-
4f163c68 clang version 12.0.0 (/src/external/llvm-project/clang
1100ebe275a9dcc79a9abbda902b6f10738f2f5d)
   LLVM version 12.0.0git
$ /opt/rocm/bin/rocminfo -v | grep -i version
Runtime Version:         1.1
$ grep -ri version /opt/rocm/include
<no results>

TomTheBear avatar Mar 23 '21 10:03 TomTheBear

Codecov Report

Merging #19 (62afaa7) into master (19e880b) will decrease coverage by 1.50%. The diff coverage is 19.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   84.26%   82.76%   -1.51%     
==========================================
  Files          14       14              
  Lines        3985     4078      +93     
==========================================
+ Hits         3358     3375      +17     
- Misses        627      703      +76     
Impacted Files Coverage Δ
machinestate.py 73.32% <19.35%> (-2.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19e880b...62afaa7. Read the comment docs.

codecov-commenter avatar Jun 04 '21 14:06 codecov-commenter