ROSS icon indicating copy to clipboard operation
ROSS copied to clipboard

improve testing

Open gonsie opened this issue 6 years ago • 5 comments

There are a number of task that should be done to improve the testing:

  • [ ] improve the setup of the Travis tests. This should involve using multiple build stages and conditional stages to test various compilers and deploy the doxygen.
  • [ ] improve how we leverage PHOLD to test various features. There should be a distinction between an instrumented phold version which can do all the things and the original phold benchmark (I'm not sure if one model code base can/should capture both of these concepts.)
  • [ ] through the improvements to a feature-rich phold test, improve our test coverage.
  • [ ] improve the cmake for generating coverage (refactor for bugs uncovered in #150)
  • [ ] improve the cmake for running tests. Right now mpirun -np is hard-coded, but it doesn't need to be.

gonsie avatar May 07 '19 20:05 gonsie

To add on to this, coverage decreased quite a bit with the merge of #149. I decided to go ahead and merge it anyway and we can work on improving coverage with the rest of these tasks.

caitlinross avatar May 16 '19 19:05 caitlinross

FYI, next month Kitware is having a CMake tutorial day. Neil and I are both going, so I plan to work work on making some more improvements to our CMake files and testing around then (plus I should be done with my thesis by then).

caitlinross avatar Jun 13 '19 15:06 caitlinross

Any updates on this? Did you guys learn any cool tips and tricks with CMake? :)

laprej avatar Jul 11 '19 13:07 laprej

Not yet. The CMake tutorial is on the 23rd! Maybe they still have some seats open if you want to attend.

caitlinross avatar Jul 11 '19 15:07 caitlinross

Excellent, I registered, thanks!

laprej avatar Jul 11 '19 15:07 laprej