rccl icon indicating copy to clipboard operation
rccl copied to clipboard
verified publisher icon ROCmSoftwarePlatform

disabling AR_Bias for gfx90a

Open mberenjk opened this issue 4 months ago • 1 comments

Details

Do not mention proprietary info or link to internal work items in this PR.

Work item: LWPCLPAT-599

What were the changes?
disabling AR_Bias for gfx90a

Why were the changes made?
The build time for AR_Bias was really long on gfx90a.

How was the outcome achieved?

Additional Documentation:
What else should the reviewer know?

Approval Checklist

Do not approve until these items are satisfied.

  • [ ] Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

mberenjk avatar Oct 21 '25 02:10 mberenjk

I don't think this is problem because we are now using a keyed map instead of an index-based array, but: Is there any chance that conditionally including these kernels could somehow mess up the lookup to cause a mismatch, which could explain why some unit tests were failing?

corey-derochie-amd avatar Oct 22 '25 18:10 corey-derochie-amd

Closing this PR, as https://github.com/ROCm/rccl/pull/2030 resolves this issue.

nileshnegi avatar Nov 10 '25 18:11 nileshnegi