rccl icon indicating copy to clipboard operation
rccl copied to clipboard

Fixed the use of the `MSCCLPP_ENABLE_CLIP` build flag

Open corey-derochie-amd opened this issue 7 months ago • 1 comments

Details

Do not mention proprietary info or link to internal work items in this PR.

What were the changes?
Actually set the compile-time define for MSCCLPP_CLIP_ENABLED when the MSCCLPP_ENABLE_CLIP flag is passed to the mscclpp cmake.

Why were the changes made?
The clip enabling feature would not have actually worked without this. It wasn't actually being defined in the C++ code at compile time, just passed to the cmake.

How was the outcome achieved?
Added the compile definition to the mscclpp CMakeLists.txt via the remove-clip.patch.

Approval Checklist

Do not approve until these items are satisfied.

  • [ ] Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

corey-derochie-amd avatar Jul 16 '25 22:07 corey-derochie-amd

@thananon @nusislam this fixes a build defect with mscclpp clipping feature, it wasn't being enabled properly. This actually shows as a warning in the build log.

corey-derochie-amd avatar Sep 05 '25 21:09 corey-derochie-amd