MIOpen icon indicating copy to clipboard operation
MIOpen copied to clipboard

Updated reduceDims for NHWC and NCHW format for forward inference CK

Open xinlipn opened this issue 1 year ago • 3 comments

Update Batchnorm forward inference to support NCHW format

CK Reference code: https://github.com/ROCm/composable_kernel/blob/a9b170b54195ab667ca814f80dd5dfbf4ad772f5/test/batchnorm/batchnorm_infer_rank_4.cpp#L91

https://github.com/ROCm/composable_kernel/blob/a9b170b54195ab667ca814f80dd5dfbf4ad772f5/profiler/include/profiler/profile_batchnorm_infer_impl.hpp#L29

xinlipn avatar Sep 03 '24 02:09 xinlipn

@xinlipn Can we also add gtest for NCHW similar to NHWC

bghimireamd avatar Sep 03 '24 12:09 bghimireamd

@xinlipn Can we also add gtest for NCHW similar to NHWC

@bghimireamd Updated gTest. But one test failed on MI200.

test_bn_infer.log

xinlipn avatar Sep 03 '24 15:09 xinlipn

@xinlipn please help watch the CI and progress of the PR. Thanks!

junliume avatar Sep 27 '24 23:09 junliume

@xinlipn @junliume https://github.com/ROCm/MIOpen/pull/3332 has been merged, this PR can be closed

averinevg avatar Oct 29 '24 12:10 averinevg