AMDMIGraphX icon indicating copy to clipboard operation
AMDMIGraphX copied to clipboard

[impr]: RENAME requirements.txt to rbuild.json

Open yiakwy-xpu-ml-framework-team opened this issue 1 year ago • 3 comments

Problem Description

Description

The name of "requirements.txt" is misleading. It is actually an internal rbuild config file (project name , branch name, commit id).

I requested to change the file name to reflect its nature so that python dependencies and C++ project (or super project) dependencies won't be mixed.

Operating System

Ubunu22.04

CPU

AMD EPYC 9534 64-Core Processor

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

Steps to Reproduce

N/A

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

pfultz2 avatar Jul 22 '24 19:07 pfultz2

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

Thank you for instant response @pfultz2. So could we use a better name to reflect this ?

So could we use a better name to do reflect this ?

We could, but cget would need to be updated to support such a name. There is this issue here to support requirments.cget and also this issue here to support requirements.cmake.

pfultz2 avatar Jul 23 '24 18:07 pfultz2