aomp icon indicating copy to clipboard operation
aomp copied to clipboard

[AOMP] Add shellcheck workflow

Open jplehr opened this issue 8 months ago • 6 comments

jplehr avatar May 12 '25 14:05 jplehr

This depends on https://github.com/ROCm/aomp/pull/1252 and makes only sense once that has landed.

jplehr avatar May 13 '25 19:05 jplehr

I think we want to wait for https://github.com/ROCm/aomp/pull/1463 to land and then use this wrapper instead of plain shellcheck in this workflow.

jplehr avatar Jun 02 '25 15:06 jplehr

As it is, the aomp-shellcheck script automatically modifies the files given as arguments in some circumstances (i.e. if they have failing checks in the "patchable" check list), which is probably not desirable for the GitHub workflow case.

jtb20 avatar Jun 02 '25 15:06 jtb20

Good point. Should there be a --check-only option or so that would point out issues and show how to use our wrapper to fix them?

jplehr avatar Jun 02 '25 15:06 jplehr

I think so, something like that.

jtb20 avatar Jun 02 '25 15:06 jtb20

I've added a new --check-only option in the version up on https://github.com/ROCm/aomp/pull/1463 now.

jtb20 avatar Jun 04 '25 11:06 jtb20