Simon Pilgrim
Simon Pilgrim
ISD::SRA handling landed at #84426 / 186565513c57cd625ea7afd7b33897adfed7e9f8
Logical shift left/right both need dealing with, but those will be combined from either VSELECT or AND nodes.
This was the kind of thing I had in mind: https://gcc.godbolt.org/z/rdh9j3ocW
@elhewaty I've started playing with some vector test coverage already - once this has landed I'll commit the tests, raise a ticket and assign it to you.
@omkar-mohanty reverse-ping
closing abandoned PR (it can be reopened if necessary)
> > Could we use value tracking and support non-constant values and non-uniform vectors? > > I don't think this transform is profitable for non-constant values. But I'd still like...
@Rajveer100 Please can you investigate the CI failures?
> @RKSimon Do you know where this pattern is generated from? If it is only introduced by SLP/LoopVec, can we just emit a reduction instead? Is this pattern left as...
@arsenm Is the recommended approach still to have a separate X86O0PreLegalizerCombiner as well?