sossoldi icon indicating copy to clipboard operation
sossoldi copied to clipboard

fix: Resolve #382 - Add safe area in "New transaction" page

Open xDefcon opened this issue 1 year ago โ€ข 4 comments

๐ŸŽฏ Description

Adds safe area padding to the bottom bar to fix overlap with system navigation in the "New transaction" page (add_page.dart).

Closes: #382

๐Ÿ“ฑ Changes

  • Added safe area to bottom bar (ADD TRANSACTION button)
  • Bug fix for UI visibility

๐Ÿงช Testing Instructions

Behaviour

  1. Open app on Android using the system's three-dot navigation bar.
  2. Tap on + (new transaction) button.
  3. Check bottom bar for overlap.

๐Ÿ“ธ Screenshots / Screen Recordings (if applicable)

ANDROID BEFORE: Screenshot_20250327-190124 |

ANDROID AFTER: Screenshot_20250327-190109

๐Ÿ” Checklist for reviewers

  • [ ] Code is formatted correctly
  • [ ] Tests are passing
  • [ ] New tests are added (if needed)
  • [ ] Style matches the figma/designer requests
  • Tested on:
    • [ ] iOS
    • [ ] Android

xDefcon avatar Mar 27 '25 18:03 xDefcon

Code changes LGTM! I haven't tested on any device tho and I can't modify the checklist

bongio94 avatar Mar 28 '25 07:03 bongio94

@xDefcon Hi, could you check the conflicts when you have time so we merge it?

napitek avatar Apr 29 '25 17:04 napitek

@napitek Hi, I resolved the conflicts and added a new commit to adopt the updated code formatting style, which was merged after this PR was created, causing the checks to fail.

xDefcon avatar Apr 29 '25 20:04 xDefcon

@bongio94 I think this can be merged

xDefcon avatar Apr 30 '25 18:04 xDefcon