vscode-R icon indicating copy to clipboard operation
vscode-R copied to clipboard

vscode version constraint may need bumping

Open dpastoor opened this issue 2 years ago • 0 comments

When using older versions of vscode (particularly vscode server in posit workbench) - we see that the extension on startup fails with version constraint

image

The last 2 posit workbench versions are both on 1.79.

Describe the bug A clear and concise description of what the bug is.

To Reproduce

install the REditorSupport extension

image

Open the developer tools and see the error in the console

Can you fix this issue by yourself? (We appreciate the help)

Uncertain - is it as easy as bumping https://github.com/REditorSupport/vscode-R/blob/master/package.json#L29 to a more recent version?

If it was possible to know which 1.82 api's were introduced with the new release, I may be able to help figure out/test backwards compat. We discovered this with one quarto extension that accidentally introduced the use of a new api and broke similarly, and wrapped it in a conditional to get around it.

Expected behavior Extension starts up cleanly

Screenshots Screenshots attached above

Environment (please complete the following information):

  • OS: Linux, Ubuntu 22.04
  • VSCode Version: [e.g. 1.79.2]
  • R Version: N/A
  • vscode-R version: 2.8.2

Additional context

Downgrading back to 2.8.1 manually works and the extension (unsurprisingly) works fine for that version since it was released prior to 1.82.

Its worth noting that the marketplace/vscode does suitably filter the version - for example, extensions that have newer versions that rely on more recent versions of vscode will fallback to older version - so the user outcome with proper bounds would be the most recent version for people on new version(s), and 2.8.1 for the older versions.

dpastoor avatar Jan 17 '24 00:01 dpastoor