"terminal.integrated.focusAfterRun" setting does not take effect because of the conflict against "r.source.focus"

[jooyoungseo]

Type: Bug

In the latest VSCode insiders, "terminal.integrated.focusAfterRun" setting has been introduced.

However, "r.source.focus" seems to override the value so I cannot benefit from it. For example, screen reader users need to focus in accessible-buffer after sending code to terminal, but currently, it is prevented due to "r.source.focus" value.

Reprex

1. Update VSCode insiders to the latest version.

2. Change the settings.json as follows:

{
  "terminal.integrated.defaultLocation": "editor",
  "terminal.integrated.focusAfterRun": "accessible-buffer"
}

Current Behavior

Focus does not move to the accessible terminal buffer

Expected Behavior

Focus needs to move to the accessible terminal buffer.

Notes

This issue does not occur when {"terminal.integrated.defaultLocation": "view"}.

Extension version: 2.8.1 VS Code version: Code - Insiders 1.82.0-insider (35be9bf683eace09796e59d54f1f225bbc3a7866, 2023-08-30T05:33:47.972Z) OS version: Windows_NT x64 10.0.22621 Modes:

System Info

Item	Value
CPUs	11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	15.71GB (6.89GB free)
Process Argv	--crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader	yes
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
a9j8j154:30646983
showlangstatbar:30737417
ecj1e332:30687743
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
gsofa:30797620
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
copilotsettingt:30808721
asynctok:30821568
dsvsc013:30777762
dsvsc014:30777825
diffeditorv2:30786206
pythonlinttype:30823781
pythonmpsinfo:30815194
dsvsc015:30821418

[jooyoungseo]

@meganrogge -- Just FYI, in some extensions, "terminal.integrated.focusAfterRun" setting is not working well when "terminal.integrated.defaultLocation": "editor".