NorthstarMasterServer Added 404 page

Thought it might be better than having a raw json error

Jul 01 '22 11:07 taskinoz

Noice :D

The only potential that comes to mind is that Internet background noise scanning random pages will hit 404s a lot which will also trigger downloading the video. Given however that video is cached on CloudFlare edge that's probably not gonna be an issue ^^

@barnabwhy wanna maybe take a look and leave review so I can merge it?

Jul 01 '22 12:07 GeckoEidechse

@GeckoEidechse it should be fine given it's cached and the status code is set. Any non-humans that encounter 404 tend to not attempt to render the web page

Jul 01 '22 13:07 barnabwhy

I could look at making it much smaller and just having an image or svg instead of a video

Jul 02 '22 10:07 taskinoz

I could look at making it much smaller and just having an image or svg instead of a video

Nah, it's fine. As barnaby said, it's likely not an issue. We'll just test in prod and if we start noticing issues with MS, we just revert and go for lower bandwidth solution ^^

Jul 02 '22 10:07 GeckoEidechse

If you are planning to continue working on this, it needs to be re-submitted against R2Northstar/NorthstarTF and R2Northstar/Atlas.

Oct 22 '22 04:10 pg9182