qwik icon indicating copy to clipboard operation
qwik copied to clipboard

[✨] Tailwind CSS Integration Overwrites .vscode/settings.json

Open marcos-padilla opened this issue 2 years ago • 6 comments

Is your feature request related to a problem?

Tailwind CSS Integration Overwrites .vscode/settings.json

Describe the solution you'd like

Preserve Emmet Configuration for .tsx Files and Maintain 'class' and 'for' Attributes Instead of 'className' and 'htmlFor'

Describe alternatives you've considered

Instead of overwriting the entire .vscode/settings.json file, I recommend adding the following configuration at the end of the file:

"css.lint.unknownAtRules": "ignore"

By doing this, VS Code can continue to interpret .tsx files as Qwik files, and Emmet functionality will remain unaffected, allowing for a seamless integration of Tailwind CSS without compromising Qwik file interpretation."

Additional context

No response

marcos-padilla avatar Oct 07 '23 02:10 marcos-padilla

Any chance you could creat a PR to fix it. I am happy to guide you through it.

mhevery avatar Oct 10 '23 16:10 mhevery

i would like to work on this, please guide me. like how to perform test and all.

saisrikardumpeti avatar Oct 11 '23 08:10 saisrikardumpeti

Yes, I'll be glad to work on it

marcos-padilla avatar Oct 11 '23 12:10 marcos-padilla

  • https://github.com/BuilderIO/qwik/blob/main/CONTRIBUTING.md
  • the tailwind integration is here: https://github.com/BuilderIO/qwik/tree/main/starters/features/tailwind
  • Settings are here: https://github.com/BuilderIO/qwik/blob/main/starters/features/tailwind/.vscode/settings.json
  • CLI code lives here: https://github.com/BuilderIO/qwik/tree/main/packages/qwik/src/cli you can test it with pnpm cli to see if it works correctly.
  • Here is an example of how special files are merged like package.json https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/cli/add/update-files.ts#L26 I assume we should add code here to merge .vscode/settings.json

This should be a good place to start. Let me know where other issues you run into.

mhevery avatar Oct 12 '23 17:10 mhevery

I see that this issue is still open. Can you assign me this and i will work on it?

thecoder93 avatar Jun 28 '24 12:06 thecoder93

Here we go @thecoder93 thanks

gioboa avatar Jun 28 '24 12:06 gioboa